Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add plan9 support #626

Closed
wants to merge 1 commit into from
Closed

Conversation

Elbehery
Copy link
Member

Signed-off-by: Mustafa Elbehery <[email protected]>
@fuweid
Copy link
Member

fuweid commented Dec 1, 2023

I don't have plan9 env to verify it.

If we have to support multiple platforms, I think bbolt should consider use QEMU/virt for testing.
Without testing env, it's easy to break the change.

@Elbehery
Copy link
Member Author

Elbehery commented Dec 1, 2023

I dont have plan9 either :/

@ahrtr
Copy link
Member

ahrtr commented Dec 3, 2023

Thanks @Elbehery for the PR.

Just as I mentioned in #587 (comment), it isn't difficult to make code change, but we do not have real plan9 environment nor proper test suite (e.g. qemu, FYI. #577) to verify the PR.

Proposed actions:

  • I expect someone who has real plan9 environment to contribute & verify the PR.
  • Please anyone feel free to introduce qemu to verify all the existing platforms which are supported by bbolt.

Will close this PR for now.

@ahrtr ahrtr closed this Dec 3, 2023
@ahrtr ahrtr mentioned this pull request Dec 3, 2023
@Elbehery Elbehery deleted the add_plan9_support branch January 12, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Building on Plan 9 fails
3 participants